Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bind): edge case of same-user binding #1319

Merged
merged 2 commits into from
Dec 25, 2023
Merged

feat(bind): edge case of same-user binding #1319

merged 2 commits into from
Dec 25, 2023

Conversation

XxLittleCxX
Copy link
Member

No description provided.

@XxLittleCxX XxLittleCxX added the bug BUG label Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0294c38) 88.14% compared to head (05ce853) 88.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   88.14%   88.15%   +0.01%     
==========================================
  Files          37       37              
  Lines        5322     5327       +5     
  Branches     1058     1060       +2     
==========================================
+ Hits         4691     4696       +5     
  Misses        631      631              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably adding some hint text is better.

@shigma shigma changed the title fix(bind): cross platform binding feat(bind): edge case of same-user binding Dec 25, 2023
@shigma shigma merged commit 0bbed71 into master Dec 25, 2023
13 checks passed
@shigma shigma deleted the bind-fix branch December 25, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug BUG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants