Add plugin-baidu #153
Merged
Add plugin-baidu #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #153 +/- ##
========================================
Coverage 90.89% 90.89%
========================================
Files 53 53
Lines 10122 10122
Branches 1981 1981
========================================
Hits 9200 9200
Misses 922 922 Continue to review full report at Codecov.
|
dragon-fish
commented
Mar 15, 2021
packages/plugin-tools/src/baidu.ts
Outdated
| koishi | ||
| .command('tools/baidu <keyword>', '使用百度百科搜索') | ||
| .example('百度一下最终幻想14') | ||
| .shortcut(/^百度(一下)?(.+?)$/, { args: ['$2'] }) |
There was a problem hiding this comment.
实践证明目前的shortcut非常容易误触，请看情况改进一下。
packages/plugin-tools/src/baidu.ts
Outdated
| Number(answer) < 1 || | ||
| Number(answer) > showedResult | ||
| ) { | ||
| return session.send('编号输入有误！') |
There was a problem hiding this comment.
经实践证明，这里的回复可能会有点吵。
也许可以加一个判断条件，例如输入的不是数字就不采取行动；或者回复“cancel”、“0”之类的取消搜索。
packages/plugin-tools/src/baidu.ts
Outdated
| * @param {...String} args | ||
| * @return {String} | ||
| */ | ||
| function _msg(msgKey: string, ...args: string[]): string { |
There was a problem hiding this comment.
koishi v3好像新增了一个模板语法，但我不太明白。这里可能存在重复造轮，请视情况帮忙改一改。
This comment has been minimized.
This comment has been minimized.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
依葫芦画瓢…
我说我是乱写的，我可真的是乱写的啊……