Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(teach): remove compatibility checks for regexp, fix #299 #300

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

shigma
Copy link
Member

@shigma shigma commented Jul 7, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #300 (0739045) into develop (16a22f0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #300      +/-   ##
===========================================
- Coverage    92.48%   92.47%   -0.01%     
===========================================
  Files           58       58              
  Lines        11291    11286       -5     
  Branches      2329     2329              
===========================================
- Hits         10442    10437       -5     
  Misses         849      849              
Impacted Files Coverage Δ
packages/plugin-teach/src/utils.ts 89.15% <ø> (-0.11%) ⬇️
packages/plugin-teach/src/internal.ts 94.79% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a22f0...0739045. Read the comment docs.

@shigma shigma merged commit b3c5d73 into develop Jul 8, 2021
@shigma shigma deleted the teach-regexp branch July 8, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant