-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support query expression and regex #305
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #305 +/- ##
===========================================
+ Coverage 92.67% 92.71% +0.03%
===========================================
Files 58 58
Lines 11274 11333 +59
Branches 2336 2357 +21
===========================================
+ Hits 10448 10507 +59
Misses 826 826
Continue to review full report at Codecov.
|
theme: bricks
|
或许可以同时支持 |
前面是同时支持了,后面的这个语法还没有加 我觉得后面的语法类似于 $or,mongo 里面 $or 的语法是这样的 db.query({
id: { $or: [{ $eq: 1 }, { $eq: 2 }] }
}) 我觉得 mongo 的这个语法比较可控一点,也没有引入新的学习成本 |
|
https://docs.mongodb.com/manual/reference/operator/query/#comparison 这里面的大部分操作符都可以实现,但是目前为了快速验证建议只实现一部分,实现 $in 是为了与现有的逻辑进行统一。 |
均已实现 |
已支持 mysql,待合并 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
先提这些,还有些地方没看清之后再看
* update to v3 api doc * `模拟会话` missed async
This reverts commit 9fdd926
支持 expression
暂时只是在 test utils 中的 mock database 实现了该功能
如果这个语法可以,我会接着这个 pr 将 mysql 与 mongo 实现一遍