Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make 'koishi start' works with koishi.config.yml #306

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

Anillc
Copy link
Member

@Anillc Anillc commented Jul 23, 2021

if (['.yaml', '.yml'].includes(configExt)) {

使用 yml 配置文件的时候如果直接使用 koishi start 而没有指定配置文件的话这里的 configExt 会是 undefined ,修改之后如果存在文件 configExt 就不会是 undefined 从而达到加载 yml 文件的目的了

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #306 (d690eb7) into develop (d111515) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #306   +/-   ##
========================================
  Coverage    92.67%   92.67%           
========================================
  Files           58       58           
  Lines        11274    11274           
  Branches      2336     2336           
========================================
  Hits         10448    10448           
  Misses         826      826           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d111515...d690eb7. Read the comment docs.

@shigma shigma merged commit bac8a01 into koishijs:develop Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants