feat(puppeteer): support to configure styles while rendering fragment segments #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #318 +/- ##
===========================================
+ Coverage 92.71% 92.72% +0.01%
===========================================
Files 58 58
Lines 11340 11345 +5
Branches 2361 2362 +1
===========================================
+ Hits 10514 10520 +6
+ Misses 826 825 -1
Continue to review full report at Codecov.
|
shigma
reviewed
Jul 30, 2021
shigma
requested changes
Aug 8, 2021
| @@ -268,8 +273,12 @@ export function apply(ctx: Context, config: Config = {}) { | |||
| ctx.before('eval/send', (content) => { | |||
| return segment.transformAsync(content, { | |||
| async fragment({ content }) { | |||
| const style = Object | |||
| .entries(config.bodyStyle) | |||
| .map(([key, value]) => `${hyphenate(key)}: ${value};`) | |||
There was a problem hiding this comment.
其实这里可以不要那个分号，然后下面用 join('; ') 看起来稍好一些
| @@ -64,6 +64,7 @@ export interface Config { | |||
| idleTimeout?: number | |||
| maxLength?: number | |||
| protocols?: string[] | |||
| bodyStyle?: Record<string, string> | |||
There was a problem hiding this comment.
Container 也许不是很合适，不过只要在文档里写好叫什么都没问题（
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.