Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): command option type bug #332

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

NWYLZW
Copy link
Contributor

@NWYLZW NWYLZW commented Aug 12, 2021

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #332 (f7070b4) into develop (d41c9b7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #332   +/-   ##
========================================
  Coverage    92.78%   92.78%           
========================================
  Files           57       57           
  Lines        11436    11436           
  Branches      2368     2368           
========================================
  Hits         10611    10611           
  Misses         825      825           
Impacted Files Coverage Δ
packages/koishi-core/src/parser.ts 99.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41c9b7...f7070b4. Read the comment docs.

@shigma
Copy link
Member

shigma commented Aug 12, 2021

这个 PR 是不是可以修复 #331 的问题?

@NWYLZW
Copy link
Contributor Author

NWYLZW commented Aug 12, 2021

这个 PR 是不是可以修复 #331 的问题?

y,是的,可以看我添加的两行单元测试

@shigma shigma merged commit fbf26fa into develop Aug 12, 2021
@shigma shigma deleted the yijie/fix-option-type-bug branch August 12, 2021 15:35
NWYLZW added a commit that referenced this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants