Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix Deck Layout Fix & More Indicator Options #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EnnisSec
Copy link

@EnnisSec EnnisSec commented Jan 3, 2019

Hi Brian,

here's another set of changes for your consideration - again this should not break any existing features, only introduce a new one, and also fix a bug in the process:

These changes will make the SYNC, MASTER, FLTR and LOOP n indicator fields toggleable via the displayDeckIndicators parameter in Prefs.qml.
They are not necessary on the S8, as the controller has hardware indicators for these functions. The Loop Length and Tempo Master flag have been turned into icons in the center column of the header instead. If this new option and displayPhaseMeter are both set to false, the Waveform will automatically grow to fill the space available.

Also, a display issue with Remix decks will be fixed. Before:
img_0269
After. You can see the Loop Length, and Tempo Master (Metronome) icon up top:
img_0270

Here is what a regular Stereo track looks like when displayDeckIndicators and displayPhaseMeter are true:
img_0271
...and false:
img_0272

EnnisSec and others added 5 commits January 3, 2019 01:00
- Fix the Deck Header indicators interfering with Remix Decks; The four
  indicators between the Deck Header and Waveform will now be hidden
  automatically.
- New Pref.qml option 'displayDeckIndicators': The S8 has hardware
  indicators for Sync and Filter, so if you want you can now turn them
  off. When this option is off, a circular loop indicator (like the
  stock one, but slightly smaller) will be displayed in the header, as
  well as a metronome icon to indicate the Tempo Master. If both this
  and 'displayPhaseMeter' are set to 'false', the Waveform will
  automatically grow to fill the space available.
- Change Bottom Left text container name from 'extra_middle_left_text'
  to 'bottom_left'
- Adjust center and right field widths
This makes long Titel, Artist or Comment Fields easier to read
@Stefan19782001
Copy link

Hi man, thk a lot for the screen crack but dosen"t work for Tractor pro 3.2 anymore. Can u update the crack pls?

@Stefan19782001
Copy link

is it working . thank and aslo PLEASE in browser mode from display why i cant see the key text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants