Remix Deck Layout Fix & More Indicator Options #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brian,
here's another set of changes for your consideration - again this should not break any existing features, only introduce a new one, and also fix a bug in the process:
These changes will make the
SYNC
,MASTER
,FLTR
andLOOP n
indicator fields toggleable via thedisplayDeckIndicators
parameter inPrefs.qml
.They are not necessary on the S8, as the controller has hardware indicators for these functions. The Loop Length and Tempo Master flag have been turned into icons in the center column of the header instead. If this new option and
displayPhaseMeter
are both set tofalse
, the Waveform will automatically grow to fill the space available.Also, a display issue with Remix decks will be fixed. Before:
After. You can see the Loop Length, and Tempo Master (Metronome) icon up top:
Here is what a regular Stereo track looks like when
displayDeckIndicators
anddisplayPhaseMeter
aretrue
:...and
false
: