-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenMPTarget on Intel GPUs update #6735
Conversation
@rgayatri23 Can you please review? |
Looks reasonable. You are only disabling non working unit tests. It looks like most of the failures are with algorithms and math functions, is there any idea as to whether its related to any particular set of instructions that the intel compilers are unable to execute inside OpenMP's |
Everything compiles but we get wrong results.
I wouldn't be surprised if the algorithm failures are our fault. The bessel function problems are likely pointing to some issues in the toolchain since we are also seeing them for SYCL. |
Everything else looks good except for the typo mentioned. |
// FIXME_NVHPC long double not supported, 23.7 long double | ||
// FIXME_OPENMPTARGET | ||
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \ | ||
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU)) | ||
TestNumericTraits<TEST_EXECSPACE, long double, Infinity>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These actually cause segfaults.
Fixed. |
Seeing
for the OpenMPTarget` build but that looks unrelated to this pull request. |
This pull request updates the linker flags for OpenMPTarget on Intel GPUs matching what we are doing for SYCL and disables failing tests. Interestingly, we see problems both for SYCL and OpenMPTarget with the bessel functions but we have more failures with the latter.
I reported the test failures to Argonne folks.