Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New extents implementation #212

Merged
merged 33 commits into from
Apr 4, 2023
Merged

New extents implementation #212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
08a38fd
Add new implementation of extents and maybe_static_array
crtrott Nov 22, 2022
b14a750
Add changes in layouts and mdspan to support new extents
crtrott Nov 22, 2022
c17c896
Enable new extents implementation
crtrott Nov 22, 2022
f99b51c
Disable temporarly submdspan tests
crtrott Nov 22, 2022
f0ff77c
Fix a bunch of unsigned/signed warnings in new extents impl
crtrott Dec 23, 2022
33ff7da
Replace requires clause with C++14 backward macro
crtrott Dec 23, 2022
001a161
Protect use of span in new extents impl
crtrott Dec 23, 2022
3aa022b
Make new extents impl compile with C++14
crtrott Dec 23, 2022
cd54023
Add function markup to new extents implementation
crtrott Dec 23, 2022
15e6224
Get new extents to work with nvcc
crtrott Feb 1, 2023
6e93f6f
Fix a bit more stuff for NVCC build
crtrott Feb 1, 2023
e873312
Clang-format
crtrott Feb 1, 2023
65d550e
Delete old extents
crtrott Mar 15, 2023
b83ac2f
Renamed new extents file
crtrott Feb 1, 2023
e550a7f
Remove implementation detail files for old extents
crtrott Feb 1, 2023
02481f7
Get rid of some old extents use code
crtrott Feb 1, 2023
69a9abb
Add missing copyright
crtrott Feb 1, 2023
ea1d9ca
Update comments in extents implementation
crtrott Feb 3, 2023
176bc07
Some code cleanup for extents based on code review
crtrott Feb 3, 2023
0c6baec
Fix a test for explicit conversion construction of extents
crtrott Feb 3, 2023
99ed11b
Fix some small deviations from standard for new extents
crtrott Feb 3, 2023
d036d5f
Apply suggestions from code review
crtrott Feb 9, 2023
49e1162
Fix MSVC 14 issue
crtrott Mar 15, 2023
cd39b4c
Add static assertion to check saneness of types in maybe_static_array
crtrott Mar 16, 2023
002f2ad
Fix use of int and don't compile benchmarks in C++23 mode
crtrott Mar 16, 2023
2a782c2
Apply suggestions from code review
crtrott Apr 3, 2023
588a50a
Make maybe-static-array dyn_map_t private
crtrott Apr 3, 2023
b568d51
Make static_array inherit from its impl type, and check extents mandate
crtrott Apr 3, 2023
d9f4715
Remove some leftover newextents/oldextents stuff
crtrott Apr 4, 2023
952be00
Fix two build issues on NVHPC
crtrott Apr 4, 2023
e78a29c
Remove unused function in the scan
crtrott Apr 4, 2023
c93cd34
Fix build of examples with bracket operator
crtrott Apr 4, 2023
2d8f8ef
Apply suggestions from code review
crtrott Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/experimental/__p0009_bits/extents.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#endif
#include <array>

#include<inttypes.h>
crtrott marked this conversation as resolved.
Show resolved Hide resolved

namespace std {
namespace experimental {
namespace detail {
Expand Down
3 changes: 2 additions & 1 deletion include/experimental/__p0009_bits/mdspan.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ class mdspan
#else
MDSPAN_INLINE_FUNCTION_DEFAULTED constexpr mdspan()
requires(
(rank_dynamic() > 0) &&
// nvhpc has a bug where using just rank_dynamic() here doesn't work ...
(extents_type::rank_dynamic() > 0) &&
_MDSPAN_TRAIT(is_default_constructible, data_handle_type) &&
_MDSPAN_TRAIT(is_default_constructible, mapping_type) &&
_MDSPAN_TRAIT(is_default_constructible, accessor_type)
Expand Down