Address issue #229 and fix missing noexcept #230
Conversation
|
This addresses issue #229 hopefully. |
| throw std::runtime_error("Assigning layout_stride to layout_left with invalid strides."); | ||
| // Note this throw will lead to a terminate if triggered since this function is marked noexcept |
There was a problem hiding this comment.
why not just call assert in that case?
There was a problem hiding this comment.
To clarify @dalg24 's comment: assert does something exactly when not defined(NDEBUG) is true, so this should behave effectively like assert. Furthermore, an actual assert may have a better error message, as a noexcept violation might not need to print the exception message.
The nicer way to do this would be to define an MDSPAN_ASSERT macro that Does The Right Thing, but I think it's fine for now just to use assert.
There was a problem hiding this comment.
I would need to write a function I call inside the assert I guess? Because I don't want to execute the loop unless !NDEBUG
Or do you just want me to replace the innermost if/throw?
There was a problem hiding this comment.
immediately invoked lambda code was worse. reverted to the initial PR
crtrott
force-pushed
the
fix_noexcept_missing
branch
from
a8f8b85
to
bd59063
Compare
The conversion operators from layout_stride for both layout_left and layout_right were missing a static_cast and also were not marked noexcept. I now guard the precondition check with NDEBUG. Note: the throw in there is legal: it will result in a termination if triggered since the function is marked noexcept.
crtrott
force-pushed
the
fix_noexcept_missing
branch
from
bd59063
to
f533312
Compare
Permit C++ < 20
The conversion operators from layout_stride for both layout_left and layout_right were missing a static_cast and also were not marked noexcept. I now guard the precondition check with NDEBUG.
Note: the throw in there is legal: it will result in a termination if triggered since the function is marked noexcept.