Enable testing with SYCL #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
reviewed
Jan 27, 2023
tests/test_mdarray_ctors.cpp
Outdated
| @@ -181,9 +181,12 @@ void test_mdarray_ctor_data_carray() { | |||
| free_array(errors); | |||
| } | |||
|
|
|||
| // host data can't be used in device code | |||
There was a problem hiding this comment.
What host data does the test use? I'm guessing that the mdarray is defaulting to vector as its container; should we consider changing that to array so that the test can remain enabled, or does the test really depend on using vector?
There was a problem hiding this comment.
Yes, I basically meant std::vector. I pushed a commit using std::array in the test case instead which works with SYCL but I would guess not with Cuda or HIP.
mhoemmen
approved these changes
Jan 27, 2023
|
Will conflict with #233 |
|
SYCL testing doesn't seem to work inside the runner. But that wasn't really the intend of the runner anyway. So I think we should just revert the change to the test config thing. |
crtrott
approved these changes
Jan 30, 2023
mhoemmen
added a commit
to mhoemmen/mdspan
that referenced
this pull request
Jul 26, 2023
This hopefully will prevent github from loading the cached mdspan for PR kokkos#234. The cached mdspan has the wrong tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to #223 but for SYCL.