Remove special gcc check #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is no longer used.
The current code works with GCC 7 and later.
mhoemmen
reviewed
Feb 13, 2023
mhoemmen
approved these changes
Feb 13, 2023
|
hold off this fails with NVCC |
|
(we effectively implicitly disabled CTAD for most CUDA versions because most didn't support GCC11 anyway). |
doesn't work up through NVCC 12
Crashes with internal compiler error. Tested 11.2, 11.4, 11.6 with gcc
9/10
/ascldap/users/crtrott/Kokkos/mdspan/include/experimental/__p0009_bits/mdspan.hpp:
In member function 'virtual void
TestMdspanCTAD_extents_pack_Test::TestBody()':
/ascldap/users/crtrott/Kokkos/mdspan/include/experimental/__p0009_bits/mdspan.hpp:78:25:
internal compiler error: in tsubst, at cp/pt.c:14560
78 | MDSPAN_INLINE_FUNCTION static constexpr size_t rank() noexcept
{ return extents_type::rank(); }
mhoemmen
approved these changes
Feb 15, 2023
crtrott
approved these changes
Feb 15, 2023
mhoemmen
added a commit
to mhoemmen/mdspan
that referenced
this pull request
Jul 26, 2023
Thanks to Yu You for the reproducer. This may fix kokkos#242, though I don't have an MSVC 2022 build set up to reproduce. This change fixes the GCC 9.4.0 build (after adding the reproducer).
mhoemmen
added a commit
to mhoemmen/mdspan
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is tested to work with major GCC versions (from GCC 7 on).
This will close issue #222.