Fix an ICE on MSVC 14.3X #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
approved these changes
Mar 13, 2023
| @@ -163,7 +163,7 @@ class layout_left::mapping { | |||
| ) | |||
| _MDSPAN_HOST_DEVICE | |||
| constexpr index_type operator()(Indices... idxs) const noexcept { | |||
| return __compute_offset(__rank_count<0, extents_type::rank()>(), idxs...); | |||
| return __compute_offset(__rank_count<0, extents_type::rank()>(), static_cast<index_type>(idxs)...); | |||
There was a problem hiding this comment.
We discussed these changes. They conform with the spec, as far as I can tell.
crtrott
approved these changes
Mar 14, 2023
mhoemmen
added a commit
to mhoemmen/mdspan
that referenced
this pull request
Jul 26, 2023
This avoids any ODR violations for the lambda itself. It's a generic lambda, so we don't have to worry about its operator(). Fixes kokkos#246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were ported from libcudacxx.
MSVC has an issue parsing the aggregate expression comparing extents. Fixed by adding a small helper.
Left and right layout changes fixed a warning we were seeing in testing and seem to be conforming.