More CUDA fixes exposed during Kokkos integration #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This corresponds to stuff done in kokkos/kokkos#7069 |
masterleinad
approved these changes
Jun 17, 2024
nmm0
approved these changes
Jun 17, 2024
| @@ -284,8 +284,19 @@ MDSPAN_IMPL_PROPOSED_NAMESPACE::layout_left_padded<PaddingValue>::mapping<Extent | |||
| out_of_bounds ? this->required_span_size() | |||
| : this->operator()(MDSPAN_IMPL_STANDARD_NAMESPACE::detail::first_of(slices)...)); | |||
| if constexpr (dst_ext_t::rank() == 0) { // result rank-0 | |||
| using dst_mapping_t = typename layout_left::template mapping<dst_ext_t>; | |||
| return submdspan_mapping_result<dst_mapping_t>{dst_mapping_t{dst_ext}, offset}; | |||
| // The following for some reasons leads to compiler error later, while not using a typedef works: | |||
There was a problem hiding this comment.
I appreciate the detailed explanation of how this somehow broke CUDA+GCC :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.