Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Libretranslate(New Translator) #551

Merged
merged 6 commits into from
Jan 1, 2025

Conversation

penginn-net
Copy link
Contributor

@penginn-net penginn-net commented Dec 21, 2024

What

翻訳の種類にセルフホスト可能な機械翻訳API、Libretranslateを追加しました
https://github.com/LibreTranslate/LibreTranslate

Why

外部サービスを利用する翻訳はレートリミットや従量課金に影響されるため、ユーザに向けて提供しずらいです。
そのため、セルフホスト型翻訳APIを追加して管理者が翻訳機能をより提供しやすくします

Additional info (optional)

Api Endpoint: http://translator:5000

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (d415d09) to head (bdedaae).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #551   +/-   ##
========================================
  Coverage    99.45%   99.45%           
========================================
  Files            4        4           
  Lines         6269     6269           
  Branches        33       33           
========================================
  Hits          6235     6235           
  Misses          34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 21, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -521,6 +521,18 @@
                     "deeplIsPro": {
                       "type": "boolean"
                     },
+                    "libreTranslateEndPoint": {
+                      "type": [
+                        "string",
+                        "null"
+                      ]
+                    },
+                    "libreTranslateApiKey": {
+                      "type": [
+                        "string",
+                        "null"
+                      ]
+                    },
                     "defaultDarkTheme": {
                       "type": [
                         "string",
@@ -805,6 +817,8 @@
                     "backgroundImageUrl",
                     "deeplAuthKey",
                     "deeplIsPro",
+                    "libreTranslateEndPoint",
+                    "libreTranslateApiKey",
                     "defaultDarkTheme",
                     "defaultLightTheme",
                     "description",
@@ -15685,6 +15699,18 @@
                     "type": [
                       "string",
                       "null"
+                    ]
+                  },
+                  "libreTranslateEndPoint": {
+                    "type": [
+                      "string",
+                      "null"
+                    ]
+                  },
+                  "libreTranslateApiKey": {
+                    "type": [
+                      "string",
+                      "null"
                     ]
                   },
                   "enableEmail": {

Get diff files from Workflow Page

@penginn-net penginn-net marked this pull request as draft December 28, 2024 17:03
@penginn-net penginn-net marked this pull request as ready for review December 30, 2024 19:23
@noridev noridev self-requested a review January 1, 2025 13:01
@noridev noridev merged commit 6e4b1de into kokonect-link:develop Jan 1, 2025
25 of 34 checks passed
@noridev
Copy link
Collaborator

noridev commented Jan 1, 2025

ありがとうございます!🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants