Version: Change go_version to based on runtime, add additional #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that go is statically compiled, I'm not sure why GoVersion is linked at build time, vs using runtime directly. Also, add it some additional runtime variables. While seemingly superfluous, these can add clarity in the rosetta2 environment.
|
I am not aware of any problem with the new approach. Perhaps the |
|
Not sure either. This change LGTM. |
groob
reviewed
Dec 28, 2020
| @@ -53,7 +56,9 @@ func Version() Info { | |||
| Version: version, | |||
| Branch: branch, | |||
| Revision: revision, | |||
| GoVersion: goVersion, | |||
There was a problem hiding this comment.
Should probable be a TODO to delete this global or mark it as deprecated? I understand not wanting to break any scripts still setting it.
There was a problem hiding this comment.
I swapped it runtime.Version(), which seems a little superfluous with calling runtime. but fits nicely with the PrintFull function. 🤷 Not sure this really gets any use
There was a problem hiding this comment.
My point is that the goVersion variable in the var block is now unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that go is statically compiled, I'm not sure why GoVersion is linked at build time, vs using runtime directly.
Also, add it some additional runtime variables. While seemingly superfluous, these can add clarity in the rosetta2 environment.
@groob @zwass You both might know the history here. Is this a bad idea?