Rework Windows Services (#426)

We have a couple of hard to support windows corner cases. I think these stem from the difference between windows services, and traditional unix daemons. This makes them more approachable.

**Moves the windows startup process** to being explicit, instead of autodetected on whether it's in windows and non-interactive. Now there are `svc` and `svc-foreground` subcommands. This should remove a source of strange errors when interactivity is mis-detected, and also makes it easier to run launcher in various modes for debugging.

**Remove the service management** This removes the service management tools. That's better handled by the packaging.

**Change the flag parsing** from `kit/env` to `ff`. This should allow us to more easily pass in a flag file.

cmd/launcher/launcher.go

@@ -178,20 +178,6 @@ func runSocket(args []string) error {
 	return nil
 }
 
-func runSubcommands() error {
-	var run func([]string) error
-	switch os.Args[1] {
-	case "socket":
-		run = runSocket
-	case "query":
-		run = runQuery
-	case "flare":
-		run = runFlare
-	}
-	err := run(os.Args[2:])
-	return errors.Wrapf(err, "running subcommand %s", os.Args[1])
-}
-
 // run the launcher daemon
 func runLauncher(ctx context.Context, cancel func(), opts *options, logger log.Logger) error {
 	// determine the root directory, create one if it's not provided

cmd/launcher/main.go

@@ -1,5 +1,3 @@
-// +build !windows
-
 package main
 
 import (
@@ -10,7 +8,6 @@ import (
 	"github.com/go-kit/kit/log"
 	"github.com/go-kit/kit/log/level"
 	"github.com/kolide/kit/logutil"
-	"github.com/kolide/kit/version"
 	"github.com/pkg/errors"
 )
 
@@ -27,24 +24,12 @@ func main() {
 		}
 	}
 
-	opts, err := parseOptions()
+	opts, err := parseOptions(os.Args[1:])
 	if err != nil {
 		level.Info(logger).Log("err", err)
 		os.Exit(1)
 	}
 
-	// handle --version
-	if opts.printVersion {
-		version.PrintFull()
-		os.Exit(0)
-	}
-
-	// handle --usage
-	if opts.developerUsage {
-		developerUsage()
-		os.Exit(0)
-	}
-
 	logger = logutil.NewServerLogger(opts.debug)
 
 	ctx, cancel := context.WithCancel(context.Background())
@@ -56,14 +41,16 @@ func main() {
 }
 
 func isSubCommand() bool {
-	if len(os.Args) != 2 {
+	if len(os.Args) < 2 {
 		return false
 	}
 
 	subCommands := []string{
 		"socket",
 		"query",
 		"flare",
+		"svc",
+		"svc-fg",
 	}
 
 	for _, sc := range subCommands {
@@ -74,3 +61,21 @@ func isSubCommand() bool {
 
 	return false
 }
+
+func runSubcommands() error {
+	var run func([]string) error
+	switch os.Args[1] {
+	case "socket":
+		run = runSocket
+	case "query":
+		run = runQuery
+	case "flare":
+		run = runFlare
+	case "svc":
+		run = runWindowsSvc
+	case "svc-fg":
+		run = runWindowsSvcForeground
+	}
+	err := run(os.Args[2:])
+	return errors.Wrapf(err, "running subcommand %s", os.Args[1])
+}