SA5001

kolide · Feb 1, 2024 · 3c9247a · 3c9247a
1 parent be86462
commit 3c9247a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/osquery/table/program_icons_windows.go b/pkg/osquery/table/program_icons_windows.go
@@ -55,10 +55,10 @@ func generateUninstallerProgramIcons() []map[string]string {
 	for key, paths := range uninstallRegPaths {
 		for _, path := range paths {
 			key, err := registry.OpenKey(key, path, registry.READ)
-			defer key.Close()
 			if err != nil {
 				continue
 			}
+			defer key.Close()
 
 			iconPath, _, err := key.GetStringValue("DisplayIcon")
 			icon, err := parseIcoFile(iconPath)
@@ -93,10 +93,10 @@ func generateInstallersProgramIcons() []map[string]string {
 	for key, paths := range productRegPaths {
 		for _, path := range paths {
 			key, err := registry.OpenKey(key, path, registry.READ)
-			defer key.Close()
 			if err != nil {
 				continue
 			}
+			defer key.Close()
 
 			iconPath, _, err := key.GetStringValue("ProductIcon")
 			icon, err := parseIcoFile(iconPath)