Use naIfError for getting process ENV (#1622)

kolide · Feb 26, 2024 · fff57aa · fff57aa
1 parent 2a1e2a9
commit fff57aa
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/ee/debug/checkups/processes.go b/ee/debug/checkups/processes.go
@@ -57,11 +57,10 @@ func (c *Processes) Run(ctx context.Context, fullWriter io.Writer) error {
 		if strings.Contains(strings.ToLower(exe), "kolide") {
 			c.kolideCount += 1
 
-			// Grab ENV vars if available -- we ignore the error because we expect
-			// this function to return `ErrNotImplementedError` on darwin
-			if envVars, err := p.EnvironWithContext(ctx); err == nil {
-				pMap["env"] = strings.Join(envVars, " ")
-			}
+			// Grab ENV vars -- available on windows/linux but not darwin;
+			// included primarily for troubleshooting browser opening issues
+			// on linux
+			pMap["env"] = naIfError(p.EnvironWithContext(ctx))
 
 			c.data[fmt.Sprintf("%d", p.Pid)] = pMap