remove old logger from local server, use slog and span http, add span_id and trace_sampled attrs to log #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
commented
Nov 14, 2023
| @@ -155,17 +142,29 @@ func (ls *localServer) LoadDefaultKeyIfNotSet() error { | |||
|
|
|||
| serverRsaCertPem := k2RsaServerCert | |||
| serverEccCertPem := k2EccServerCert | |||
|
|
|||
| ctx := context.TODO() | |||
| slogLevel := slog.LevelDebug | |||
There was a problem hiding this comment.
Does anything change this?
There was a problem hiding this comment.
no, it just felt correct to have it in one spot incase we wanted to change it
There was a problem hiding this comment.
I think if you don't plan on implementing that, it's more confusing than helpful.
There was a problem hiding this comment.
I will remove the var next time I touch this area.
RebeccaMahany
previously approved these changes
Nov 14, 2023
James-Pickett
changed the title
RebeccaMahany
approved these changes
Nov 14, 2023
directionless
approved these changes
Nov 15, 2023
| @@ -155,17 +142,29 @@ func (ls *localServer) LoadDefaultKeyIfNotSet() error { | |||
|
|
|||
| serverRsaCertPem := k2RsaServerCert | |||
| serverEccCertPem := k2EccServerCert | |||
|
|
|||
| ctx := context.TODO() | |||
| slogLevel := slog.LevelDebug | |||
There was a problem hiding this comment.
I think if you don't plan on implementing that, it's more confusing than helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1449