override log shipping level on start up #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
James-Pickett
commented
Nov 20, 2023
•
James-Pickett
commented
- adds flag override functionality for string flags
- log shipper increases / decreases shipping interval when level changed
- set log shipping level to debug for X minutes on launcher startup
James-Pickett
commented
Nov 20, 2023
|
|
||
| ls.Ping() | ||
| return ls | ||
| } | ||
|
|
||
| func (ls *LogShipper) FlagsChanged(flagKeys ...keys.FlagKey) { | ||
| // TODO: only make updates that are relevant to flag key changes |
There was a problem hiding this comment.
I will address this in follow on PR, it doesn't make anything worse ... maybe even slightly better =)
zackattack01
previously approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.