preserve ctx when dialing unix socket for desktop #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
previously approved these changes
Nov 27, 2023
James-Pickett
commented
Nov 27, 2023
| @@ -9,7 +9,8 @@ import ( | |||
| ) | |||
|
|
|||
| func dialContext(socketPath string) func(_ context.Context, _, _ string) (net.Conn, error) { | |||
There was a problem hiding this comment.
Does the return need ctx? I'm not really sure how named vars work here
There was a problem hiding this comment.
I'm not sure, so I added just incase, it shouldn't hurt anything
There was a problem hiding this comment.
actually, nvm, it's not needed
There was a problem hiding this comment.
Thank you for checking
directionless
approved these changes
Nov 28, 2023
RebeccaMahany
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we see a lot of errors communicating over desktop socket, I don't know if properly passing the context will help with that, but seems correct either way