Remove os.Exit in favor of more graceful shutdown when osquery instance can't be restarted #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/graceful-shutdown
branch
from
447fcf9 to
b520bbc
Compare
RebeccaMahany
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1387
The osquery runner currently calls os.Exit when the osquery instance dies and it cannot start a new one. In this case, the rungroup actors will never get a chance to shut down gracefully.
I've updated so that the osquery runner instead signals the osquery extension rungroup to exit its
Executefunction, allowing for a regular shutdown of all rungroup actors.