-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a timeout for killing osquery process group #1487
Add a timeout for killing osquery process group #1487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually... Can we log something if the context is canceled? Or maybe that will be in the err
anyhow
@directionless we log the returned error here: https://github.com/kolide/launcher/blob/main/pkg/osquery/runtime/runner.go#L434 In test (reducing the timeout to 10ms to force a timeout), that log looks like this for me:
Let me update the error with more information. |
@directionless updated, log looks like this in the case of timeout now:
And here's what it looks like with a taskkill error:
|
Relates to #1442
Impose a timeout on running taskkill on Windows; returns error from running taskkill so that it can be logged by the errgroup. 10 seconds seems like a very safe timeout -- in test, taskkill took around 200 ms.