Enable more revive lint rules #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
changed the title
zackattack01
previously approved these changes
Dec 13, 2023
James-Pickett
previously approved these changes
Dec 13, 2023
directionless
previously approved these changes
Dec 14, 2023
RebeccaMahany
dismissed stale reviews from directionless, James-Pickett, and zackattack01
via
bf78afc
zackattack01
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to add other revive lint rules if there are ones that people would like -- list is here: https://github.com/mgechev/revive#available-rules, with the caveat that I would rather not add the
comment-spacingsrule because it doesn't let me exclude cgo//exportcomments from linting.