[TUF] Pull autoupdate config values from config file OR command-line args #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,7 +39,7 @@ var channelsUsingNewAutoupdater = map[string]bool{ | |||
| // For now, it is only available when launcher is on the nightly update channel. | |||
| func CheckOutLatestWithoutConfig(binary autoupdatableBinary, logger log.Logger) (*BinaryUpdateInfo, error) { | |||
| logger = log.With(logger, "component", "tuf_library_lookup") | |||
| cfg, err := getAutoupdateConfig() | |||
| cfg, err := getAutoupdateConfig(os.Args[1:]) | |||
There was a problem hiding this comment.
You think os.Args, or should we be passing it in?
There was a problem hiding this comment.
Mostly just moved os.Args[1:] up from where it previously was in getAutoupdateConfig() so that I could unit test it. I don't have a strong opinion.
There was a problem hiding this comment.
@directionless I'm going to merge this as-is to move this forward, but I'm going to be doing another PR in this same area and I'm can update this there if you'd like
zackattack01
previously approved these changes
Dec 14, 2023
zackattack01
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the new autoupdater only pulls autoupdate config values (most notably the root dir and the update channel) from the config flag file, either pulling this from the command-line args or the well-known location. However, we should support setting those config values via command-line args as well; this PR implements that change.