Don't use reserved version key in logs #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
previously approved these changes
Jan 11, 2024
James-Pickett
previously approved these changes
Jan 11, 2024
|
alternatively, we could update our current "version" keyword to "launcher_version" |
|
@James-Pickett I'm fine either way -- do you have a preference? I didn't know if maybe the ingest server or something in Cloud Log relied on |
feel like using |
RebeccaMahany
dismissed stale reviews from James-Pickett and directionless
via
f611056
James-Pickett
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logshipper adds a
versionkey for current launcher version to logs, so usingversionkeys elsewhere means we miss out on that logshipper data.