If icon is unknown, use default icon #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
directionless
previously approved these changes
Jan 12, 2024
RebeccaMahany
force-pushed
the
becca/default-icon
branch
from
718058f to
cbd73e3
Compare
James-Pickett
approved these changes
Jan 12, 2024
| @@ -53,8 +42,19 @@ func getIcon(icon menuIcon) []byte { | |||
| assets.MenubarCircleXMonochromeIco, | |||
| assets.MenubarCircleXMonochromePng, | |||
| ) | |||
| case DefaultIcon: | |||
| fallthrough | |||
There was a problem hiding this comment.
TIL about the fallthrough keyword =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the icon launcher receives is unknown to it, we won't use an icon at all. This looks a little confusing because the menu bar app is still clickable, just invisible. Instead, we should fall back to using the default icon.
Testing notes
Tested by adjusting the icon written to
menu.jsoninrunner.go: