Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUF] Retry executable checks and directory renames on update download #1556

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jan 22, 2024

This is another attempt to address some of the most frequent errors in the logs that I see with the new autoupdater; they are both almost entirely Windows issues.

First:

could not download updates: [
  could not download update for launcher:
    could not add release launcher-x.y.z.tar.gz for binary launcher to library:
      could not move verified update:
        could not move staged target launcher-x.y.z.tar.gz from <root-dir>\updates\launcher\x.y.z-timestamp to <root-dir>\updates\launcher\x.y.z:
          rename <root_dir>\updates\launcher\x.y.z-timestamp C:\Program Files\Kolide\Launcher-kolide-k2\data\updates\launcher\x.y.z:
            Access is denied.
]

Second:

could not download updates: [
  could not download update for launcher:
    could not add release launcher-x.y.z.tar.gz for binary launcher to library:
      could not move verified update:
        could not verify executable:
          timeout when checking executable:
            context deadline exceeded
]

Per some previous investigation, these appear to both be timing issues, so I'm throwing some more retries in. This is a safe time to retry -- it just delays when launcher will load the new binary, but won't delay launcher startup. And it's better than having to wait another autoupdate interval to retry the download again.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review January 22, 2024 16:56
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jan 23, 2024
Merged via the queue into kolide:main with commit 4ee1d7d Jan 23, 2024
26 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/tuf-win-retries branch January 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants