overwrite multislogger.Logger memory rather than reassigning pointer #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
force-pushed
the
james/reset-slogger-after-add-handler
branch
from
4ed228a to
3b0caf8
Compare
James-Pickett
changed the title
directionless
previously approved these changes
Feb 2, 2024
ee/agent/knapsack/knapsack.go
Outdated
| @@ -51,7 +51,7 @@ func New(stores map[storage.Store]types.KVStore, flags types.Flags, db *bbolt.DB | |||
| } | |||
|
|
|||
| if k.slogger != nil { | |||
| k.slogger.Logger = k.slogger.Logger.With("launcher_run_id", k.launcherRunId) | |||
| *k.slogger.Logger = *k.slogger.Logger.With("launcher_run_id", k.launcherRunId) | |||
There was a problem hiding this comment.
This spot feels like it breaks an abstraction. Somehow it feels wrong for knapsack to be reaching into slogger.Logger. But 🤷 not the end of the world
There was a problem hiding this comment.
I agree, it's a weird spot. Knapsack needs access to the multislogger to be able to add handlers. We also want the launcher_run_id to be universally included in all logs ..... hmm maybe multislogger should just add it, then knapsack can stop reaching in there
There was a problem hiding this comment.
I moved this down to the multislogger, now knapsack is staying in it's lane and not reaching down into multislogger's guts
RebeccaMahany
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that some logs in main func were not getting shipped. When adding a handler we can overwrite the the memory address of the multslogger.Logger to make handlers propagate to previously assigned Loggers.