Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add small wait before performing time machine exclusion test assertions #1595

Merged
merged 1 commit into from
Feb 9, 2024
Merged

add small wait before performing time machine exclusion test assertions #1595

merged 1 commit into from
Feb 9, 2024

Conversation

James-Pickett
Copy link
Contributor

No description provided.

directionless
directionless approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could try this. Could use backoff

@James-Pickett
Copy link
Contributor Author

Could try this. Could use backoff

lets try this first and if we still have issues, we can try back off... I think the back of is a little more involved in the test due to using the testing pkg that wan't to fail immediately

@James-Pickett James-Pickett added this pull request to the merge queue Feb 9, 2024
Merged via the queue into kolide:main with commit f8d0bea Feb 9, 2024
27 checks passed
@James-Pickett James-Pickett deleted the james/timemachine-test-flake branch February 9, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@James-Pickett @directionless