[slogger] Replace logger with slogger in dataflatten/exec #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/slogger-exec-dataflatten
branch
from
d6242ff to
3e5d93f
Compare
RebeccaMahany
force-pushed
the
becca/slogger-exec-dataflatten
branch
from
3e5d93f to
11ab5c1
Compare
directionless
previously approved these changes
Feb 17, 2024
directionless
previously approved these changes
Feb 21, 2024
| opts := []dataflatten.FlattenOpts{ | ||
| dataflatten.WithLogger(logger), | ||
| dataflatten.WithSlogger(multislogger.New().Logger), |
There was a problem hiding this comment.
This is example code. It feels slightly weirf to pass multislogger. Can we pass a simple slogger instead?
There was a problem hiding this comment.
This is what we tend to copy-paste everywhere we need an unused slogger -- e.g. it's all over our unit tests. I'm not sure that this is wrong.
RebeccaMahany
force-pushed
the
becca/slogger-exec-dataflatten
branch
from
d8edf78 to
648454e
Compare
directionless
approved these changes
Feb 22, 2024
Comment on lines
+150
to
152
| if fl.debugLogging { | ||
| fl.logLevel = slog.LevelDebug | ||
| } |
There was a problem hiding this comment.
I suspect we could drop this, and simply log everything at at levelFlattenDebug and let the caller apply the appropriate filter. But 🤷 maybe better to merge
There was a problem hiding this comment.
I liked this because it works the same way it used to 🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last step for removing logger from Kolide tables -- replaces logger with slogger in dataflatten/exec.