Allow control server to pin version for osqueryd and launcher #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/control-server-set-update-version
branch
from
05ed9db to
3c3c73a
Compare
| // versionFromTarget extracts the semantic version for an update from its filename. | ||
| func versionFromTarget(binary autoupdatableBinary, targetFilename string) string { | ||
| // The target is in the form `launcher-0.13.6.tar.gz` -- trim the prefix and the file extension to return the version | ||
| prefixToTrim := fmt.Sprintf("%s-", binary) |
|
LGTM! |
zackattack01
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1577
Some users may want to pin a particular version of osqueryd or launcher. This PR enables that functionality via the TUF autoupdater.
If a pinned version is set, the autoupdater will select that version first. If it cannot find that version, then it will fall back to using the release version for the configured update channel.
While working on this PR, I noticed I had a couple related functions about parsing and comparing versions, so I've moved them into their own file and separated out their tests as well.
Also -- updated to handle control server actions during the initial delay in a clearer and more opinionated way: