add dynamic buffer size for log publication #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
force-pushed
the
zack/log_buffering_backoff
branch
from
dfa5715 to
a581cec
Compare
RebeccaMahany
previously approved these changes
Feb 29, 2024
zackattack01
force-pushed
the
zack/log_buffering_backoff
branch
from
1d48771 to
7fe0e41
Compare
RebeccaMahany
approved these changes
Feb 29, 2024
directionless
approved these changes
Mar 1, 2024
| currentBatchStartTime time.Time | ||
| } | ||
|
|
||
| func NewLogPublicationState(maxBytesPerBatch int) *logPublicationState { |
There was a problem hiding this comment.
Does this need to be exported?
There was a problem hiding this comment.
oh good catch I had meant to ask for feedback here - technically none of these need to be exported (logic is entirely self-contained in osquery). I opted to export some of these just to make it extremely clear which bits we expect to be used (NewLogPublicationState -> StartBatch -> EndBatch) vs the bits that were internal to logPublicationState. I can move those all to be internal only if people would prefer?
Comment on lines
+99
to
+101
| if lps.currentMaxBytesPerBatch >= lps.maxBytesPerBatch { | ||
| return | ||
| } |
There was a problem hiding this comment.
Nice. I suspect we'll need to figure out how to grow beyond this -- some customers have it coded really small. But maybe this is fine to start, and we can make a real max value later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to address the log buffering fragility issue noted here.
The adjustment logic took a few different forms based on testing - i also have a version of this that keeps a queue of latest results if anyone is interested in going down that route let me know (I ended up trimming this down to a more simple mechanism after seeing the complexity there).
I am more than happy to take suggestions on the adjustment logic - it's easy to make the backoff more dramatic if desired but I found it to be safest to keep the changes to small increments, if the network is really in a bad state the batch limit will be adjusted eventually.
complications/lessons learned