-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kolide_flatpak_upgradeable
table with exec parser
#1635
Conversation
787e25a
to
0c47455
Compare
kolide_flatpak_upgradeable
table with exec parser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the documentation + the thorough tests -- just one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
// | ||
// flatpak remote-ls --updates | ||
// data is separated by whitespace only | ||
// data headers aren't in stdout, they are written directly to TTY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know... we used to have an exec tool that faked a pty. We deleted it a bit ago, but https://github.com/kolide/launcher/tree/19cb2b48a4df91021132ab5b62dadbff79a74def/pkg/ptycmd
Is it worth looking at bringing that back for headers and then doing something straightforward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did go down the path of attempting to read the headers from tty, but I spent a while without making progress, so I stepped away from that solution. If there's prior art for this, then it's worth revisiting and trying out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried going down this list, but I wasn't able to get any output in my testing, so I'm going to merge this for now and revisit as needed.
(I'm pulling from the merge queue, because I want to ponder pty with micah. We can carry on if we don't want to pick that up) |
No worries, I'm good to discuss the options. |
Add a Kolide table for
flatpak
outdated packages. This one was very frustrating with howflatpak
outputs data. Perhaps I should've started with only the app id and stopping there, but I was hoping to use the newStringDelimitedLineFunc
to handle parsing theflatpak
data table flatpak-table-printer.c. I was defeated in a truly brutal battle, the ages will never forget the terror that wasflatpak
tables.Besides manually defining a header list for each Linux distribution I'm not sure how we could correctly parse
flatpak remote-ls
output. I did not feel like doing that at the moment, so that's why I've settled on only app id.