Refactor runAsUser into tablehelper package

[Micah-Kolide]

Cleaning up the runAsUser idiom I was using in a couple of places for the table generates.

[directionless]

Hrm... this might be okay, but it is a bit of a sharp edge.

tablehelpers.Exec enforces that it's called with a timeout, and ensures consistent logging. I'm not totally sure the signature is correct, but it does unify a lot of things.

In contrast, this takes a cmd and runs it. Which, in some ways, is a better idiom. But I'm not sure how we can enforce things like timeouts, and create consistent logging.

I'd be inclined to make a functional argument on tablehelpers.Exec that takes RunAs(uid)

The more arduous path would be to rethink how we handle exec. I can imagine passing cmd around, and maybe there are other patterns.

Curious where y'all land

[RebeccaMahany]

I don't feel strongly about it either way. I think enforcing the timeout/logging is a plus, but I'm not terribly worried about not enforcing either since we do a good job including that in the first place and/or requesting it in code review.

[directionless]

Looks pretty good. As Becca said -- drop the WithUid into a _posix flavor.

[RebeccaMahany]

🔥