add menu update change detection logs #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a
menuItemCacheto the desktop runner to detect when changes to the top level items occur for the menu bar data.Within the menu template that is sent down, there are several timestamps and links that change regularly but are not meaningful for our change detection purposes. The simplest approach I found to filtering this noise was to catalog the top level items by label, and note any changes there. This will provide us with a record of any major changes (pending registrations, device status change, etc) without being too noisy. This logic is fairly isolated and easy to update if anyone has better ideas for detection or if there's more we'd want to track