-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize how we log and handle panics #1692
Merged
RebeccaMahany
merged 9 commits into
kolide:main
from
RebeccaMahany:becca/win-runLauncher-panic-log
Apr 30, 2024
Merged
Standardize how we log and handle panics #1692
RebeccaMahany
merged 9 commits into
kolide:main
from
RebeccaMahany:becca/win-runLauncher-panic-log
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
previously approved these changes
Apr 25, 2024
James-Pickett
previously approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
zackattack01
previously approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
James-Pickett
previously approved these changes
Apr 30, 2024
57233f3
directionless
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1693
If one goroutine panics, all of launcher will terminate. Before termination, the panic will travel up to the top-level function in the executing goroutine. If we want to recover or log panics, we must do that in this top-level function.
This PR introduces
gowrapper
to wrap our goroutines, to make it easier to standardize recovering from and logging panics. It will always log the panic, and allows for providing anonPanic
function that executes if gowrapper recovers from a panic.This PR adds
gowrapper
usage to our windows service and to all of our rungroups.References:
Example logs from panic inside a rungroup
Example logs from panic inside Windows service