Add initial_version to launcher info table, update a log line
#1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
previously approved these changes
Jun 7, 2024
| "serial", serialChanged, | ||
| "hardware_uuid", hardwareUUIDChanged, | ||
| "munemo", munemoChanged, | ||
| ) |
There was a problem hiding this comment.
This data also gets logged on ~85 if any of them are true -- want to remove that extra log since it'd be redundant with this one?
There was a problem hiding this comment.
I tweaked a little. How's this?
There was a problem hiding this comment.
Looks reasonable to me!
There was a problem hiding this comment.
arrg. Committed too much. must revert
directionless
force-pushed
the
seph/tweaks
branch
from
44fea29 to
6bc3794
Compare
RebeccaMahany
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've often wanted to know what the initial launcher version is. But, we don't expose that anywhere. This is a fairly simple addition that should help expose how launcher is running. Fixes #1740
Also tweak a log line about resetting the database.