Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KATC/IndexedDB] Handle padding after property name #1786

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

RebeccaMahany
Copy link
Contributor

Noticed an issue where data wasn't getting parsed properly and it was because we weren't discarding padding tokens after reading the object property name. This PR corrects that issue.

I also added a little bit of logging that I thought might be helpful for troubleshooting in the future, since we already have access to the slogger anyway.

@RebeccaMahany RebeccaMahany enabled auto-merge July 18, 2024 15:23
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jul 18, 2024
Merged via the queue into kolide:main with commit ad9419e Jul 18, 2024
20 of 21 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/indexeddb-key-padding branch July 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants