download osqueryd when missing on startup #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
approved these changes
Jul 18, 2024
| ] | ||
| }`) | ||
|
|
||
| if err = tufAutoupdater.Do(actionReader); err != nil { |
There was a problem hiding this comment.
This is very elegant. I might suggest exposing tufAutoupdater.DoNow or something, because hardcoding the wireprotocol here will totally come back to bite us. But this is very tidy.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1776, where we discovered that installing an MSI with an older version of osqueryd over a newer version leaves the launcher installation with no osqueryd.exe on windows.
There are several potential approaches here (e.g. via WiX configuration changes, path versioning etc.) but we already have all of the logic we need to download osqueryd (via autoupdates) so lets do that.
There are also several different ways to integrate/repurpose the autoupdate logic for this and I'd love to hear any alternative suggestions- this was the cleanest approach I could find that didn't require excessive refactoring of that code.
Tested by building a custom 1.9.3 MSI with these changes + an older osqueryd binary. Installing removes the osqueryd.exe on disk (as expected), but the download is triggered immediately and launcher keeps going happily once that process finishes