Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameter #1790

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove unused parameter #1790

merged 1 commit into from
Jul 23, 2024

Conversation

RebeccaMahany
Copy link
Contributor

Cleaning up an unused parameter in the sqlite package.

directionless
directionless approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, okay. But it feels wrong. 😆

Migrations should have timeouts, and that should be linked back to a context...

@RebeccaMahany
Copy link
Contributor Author

@directionless -- I agree, but unfortunately the migration package doesn't provide WithContext versions of these functions 😞

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jul 23, 2024
Merged via the queue into kolide:main with commit 9c35488 Jul 23, 2024
30 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/unusedparam-sqlite branch July 23, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @directionless