Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log table_type correctly in KATC logs #1792

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Log table_type correctly in KATC logs #1792

merged 2 commits into from
Jul 24, 2024

Conversation

RebeccaMahany
Copy link
Contributor

Fixes table_type being set to {} in logs.

directionless
directionless previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be

ee/katc/table.go Outdated Show resolved Hide resolved
@RebeccaMahany
Copy link
Contributor Author

Would this be

@directionless did some of this comment get truncated?

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jul 24, 2024
Merged via the queue into kolide:main with commit ddb2181 Jul 24, 2024
31 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/table_type_log branch July 24, 2024 15:38
@directionless
Copy link
Contributor

Would this be

@directionless did some of this comment get truncated?

Didn't delete it all. Was replaced by the inline comment thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

@James-Pickett James-Pickett James-Pickett approved these changes

@directionless directionless directionless left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RebeccaMahany @directionless @James-Pickett @zackattack01