Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KATC/IndexedDB] Adjust strict mode for opening leveldb-backed indexeddb #1800

Merged

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jul 25, 2024

Previously, we were using strict mode StrictAll:

const StrictAll = StrictManifest | StrictJournalChecksum | StrictJournal | StrictBlockChecksum | StrictCompaction | StrictReader | StrictRecovery

Several of these options prevent the database from being opened at all if corruption is present. It is more reasonable for our usecase to at least attempt to read the data out of the database. I have therefore opted to swap to StrictRecovery only (If present then leveldb.Recover will drop corrupted 'sorted table').

@RebeccaMahany RebeccaMahany enabled auto-merge July 25, 2024 20:21
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jul 25, 2024
Merged via the queue into kolide:main with commit 58930a6 Jul 25, 2024
32 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/indexeddb-strict-mode branch July 25, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants