prevent watchdog installation for dev environments #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
previously approved these changes
Jul 26, 2024
|
|
||
| // IsKolideHostedServerURL is a convenience function to enable gating functionality for | ||
| // developer (or other non-production) deployments | ||
| func IsKolideHostedServerURL(serverURL string) bool { |
There was a problem hiding this comment.
This is a nice improvement
| @@ -153,6 +158,17 @@ func (wc *WatchdogController) Interrupt(_ error) { | |||
|
|
|||
| func (wc *WatchdogController) ServiceEnabledChanged(enabled bool) { | |||
| ctx := context.TODO() | |||
| // we don't alter watchdog installation (install or remove) if this is a non-prod deployment | |||
There was a problem hiding this comment.
We could probably also check if we're running as not-root.
There was a problem hiding this comment.
oh good call, on it!
zackattack01
force-pushed
the
zack/prevent_dev_watchdog_installation
branch
from
c7109cd to
fa9f97a
Compare
directionless
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few places already where we gate behavior on the KolideServerURL with the same checks. This adds a helper function to check a serverURL against our match criteria, and adds this check to the watchdog installation and log publication routines