james/remove wmi unneeded releases #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee/wmi/wmi.go
Outdated
Comment on lines
156
to
158
| // the memory of result is released by `defer serviceRaw.Clear()` above, | ||
| // on windows arm64 machines, calling `service.Clear()` after `serviceRaw.Release()` | ||
| // would cause a panic |
There was a problem hiding this comment.
Suggested change
| // the memory of result is released by `defer serviceRaw.Clear()` above, | |
| // on windows arm64 machines, calling `service.Clear()` after `serviceRaw.Release()` | |
| // would cause a panic | |
| // In testing, we find we do not need to `service.Release(). The memory of result is released | |
| // by `defer serviceRaw.Clear()` above, furthermore on windows arm64 machines, calling | |
| // `service.Clear()` after `serviceRaw.Release()` causes a panic |
There was a problem hiding this comment.
Or something. I think there are probably better phrases. More imperative or something
zackattack01
approved these changes
Sep 12, 2024
directionless
approved these changes
Sep 12, 2024
RebeccaMahany
added a commit
to RebeccaMahany/launcher
that referenced
this pull request
Sep 13, 2024
desktop triggers Windows Hello Fix timeout, small refactor Tidy up names, add documentation Retrieve key credential status Retrieve pubkey Get attestation windows arm64 fixes, upgrade winio and thrift (kolide#1858) Fix `autoupdate_managed` table value for MacOS 15 (kolide#1862) james/remove wmi unneeded releases (kolide#1863) Check windows service manager settings prior to setting them (kolide#1859) Co-authored-by: Michael <60191460+lurky@users.noreply.github.com> Co-authored-by: seph <seph@kolide.co> Co-authored-by: Rebecca Mahany-Horton <rebeccamahany@gmail.com> Update function signature Move to ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this by creating a small program that runs in a loop only clearing the
rawResultandrawService. After 3K iterations, memory rose to around 9MB and remained stable. After 50K iterations memory was still at 9MB. This test was performed on both arm64 and amd64.