Limit log writes by number of bytes #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, buffered log writes were limited by the total number of logs. Now they are limited by total number of bytes, and logs that are over the max size limit are dropped.
zwass
force-pushed
the
log_bytes_limit
branch
from
4de0f52 to
e60c50f
Compare
groob
reviewed
Oct 21, 2017
osquery/extension.go
Outdated
| // Default maximum number of bytes per batch (used if not specified in | ||
| // options). This 4MB limit is chosen based on the default grpc-go | ||
| // limit specified in https://github.com/grpc/grpc-go/blob/master/server.go#L51 | ||
| defaultMaxBytesPerBatch = 4 * 1024 * 1024 |
There was a problem hiding this comment.
thoughts on using 4 << 20 here? It's a more common notation for constants.
osquery/extension.go
Outdated
| // Discard logs that are too big | ||
| level.Info(e.Opts.Logger).Log( | ||
| "msg", | ||
| fmt.Sprintf( |
There was a problem hiding this comment.
use key/values instead of sprintf
|
I'm going to merge this if there are no objections. |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, buffered log writes were limited by the total number of logs. Now
they are limited by total number of bytes, and logs that are over the max size
limit are dropped.