Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jsonrpc the default for transport #1919

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

RebeccaMahany
Copy link
Contributor

The expected value for the transport flag has de facto been jsonrpc for a significant amount of time now, but that hasn't been reflected in the default value in the options. This PR updates the default.

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Oct 28, 2024
Merged via the queue into kolide:main with commit 248c29c Oct 28, 2024
32 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/transport-default branch October 28, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants