Move plugin ownership to osqueryinstance #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "go.opentelemetry.io/otel/attribute" | ||
| "go.opentelemetry.io/otel/trace" | ||
|
|
||
| "golang.org/x/sync/errgroup" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
these are very helpful 🔥
zackattack01
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1827
Relates to #1936.
In preparation for moving the extension inside the osquery instance per ADR, this PR moves plugin ownership to OsqueryInstance. This simplifies setup -- the osquery instance knows what plugins it expects to have.
This PR also moves the launcher tables to the
kolideextension with all the other tables, instead of keeping them in thekolide_grpcextension.In the next PR (finally) I will move the extension over, and remove
WithOsqueryExtensionPlugins/i.opts.extensionPluginsentirely.